[Bug binutils/29993] objcopy --merge-notes slow for large .so with many annobin notes

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29993

--- Comment #9 from Frank Ch. Eigler <fche at redhat dot com> ---
> Yes - I am afraid that the watermark protocol document is a bit out of date,
> and its rules for note merging do need to be updated.

I'd suggest not over-specifying merging, or specifying merging per se
at all.  How about only documenting the semantics of the notes for
consumers?  Any transform that preserves those semantics would be fine.


> [...]
> With this patch applied I found that merging libxul.so went down from 10.5
> minutes to 5 minutes on my local machine.  Not an order of magnitude
> improvement I know, but would it be enough for you ?  

Nice improvement.  I'm not in a position to set a goal.  I can only suspect
that it could be gotten down to a few seconds instead of a few minutes, but
dunno whether there are hard constraints.


> I am hesitant to rewrite the algorithm entirely because if I get it wrong I
> am likely to break the building of other packages - either by corrupting the
> notes so that annocheck then complains, or breaking the merge process so
> that the rpms do not build or something else.

Understood - that comes from being in the honoured place deep within the
buildroot. :-)  OTOH, it should be possible to mass-build a variety of
packages, run a new merger, and test it against some older and more current
annocheck consumers, to confirm no change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.