[Bug awt/26486] Graphics.fillRect extremely slow

[hendrich at informatik dot uni-hamburg dot de]

------- Comment #5 from hendrich at informatik dot uni-hamburg dot de  
2006-03-06 08:49 -------
Subject: Re:  Graphics.fillRect extremely slow

Hello Tom,

> Can you try commenting out the call to gdk_flush() in
> Java_gnu_java_awt_peer_gtk_GdkGraphics_fillRect?

Done. The animation runs mucher faster without the gdk_flush calls.
On my system with classpath cvs 20060228 and jamvm, the difference 
is about 3 repaints/second (with gdk_flush) vs 12 repaints/second 
(without gdk_flush).

I did not test with gcj again, because I did a make clean in my gcc
build directory, and I do not want to wait for another bootstrap. Sorry.

Repainting seems smooth and correct without the gdk_flush() calls,
but it would be difficult to spot bugs in my GameOfLife/FillRect demos
anyway. Note that I have changed the demo slightly to include an actual
frames/second count. This is necessary, because classpath currently
drops or coalesces a lot of repaints.


So...

I guess we should take out all the gdk_flush() calls from the several
drawXXX and fillXXX methods in GdkGraphics.c, and just use one single
gdk_flush() (if at all) just before repainting a component?

- Norman


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26486