[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure |
|
Date: |
Thu, 14 Aug 2008 06:06:43 -0600 |
|
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080708 Thunderbird/2.0.0.16 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Jim Meyering on 8/13/2008 12:50 PM:
| if (fd < 0)
| - die (_("cannot create temporary file in"), temp_dir);
| + {
| + error (0, errno, _("cannot create temporary file in %s"),
| + quote (temp_dir));
| + exit (SORT_FAILURE);
| + }
Why not the single statement error (SORT_FAILURE, errno, _(...))?
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkikH9IACgkQ84KuGfSFAYDfDwCfYIBIPEiU8O0orbqsPbYOxiPt
svcAmwWt3L3a+e7X/8sCK96d/IfOq0gn
=/eSI
-----END PGP SIGNATURE-----
- [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure, Jim Meyering, 2008/08/13
- Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure, Andreas Schwab, 2008/08/13
- Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure, Jim Meyering, 2008/08/14
- Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure,
Eric Blake <=
- Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure, Jim Meyering, 2008/08/14
- Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure, Eric Blake, 2008/08/14
- Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure, Jim Meyering, 2008/08/14