Re: [PATCH] mktemp, sort, tac: don't use undefined after mkstemp failure

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 8/14/2008 6:12 AM:
|> | +      error (0, errno, _("cannot create temporary file in %s"),
|> | +            quote (temp_dir));
|> | +      exit (SORT_FAILURE);
|> | +    }
|>
|> Why not the single statement error (SORT_FAILURE, errno, _(...))?
|
| Without the file or directory name, it's harder
| to determine which file system is in question.

But that doesn't answer my question.  error(SORT_FAILURE,...) will call
exit(SORT_FAILURE) on your behalf, since SORT_FAILURE is non-zero.  In
other words, why not let error() do the exiting, for less code on your side?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkikJQkACgkQ84KuGfSFAYAt6ACgzHBxKD+kNepdJPkKFLotYUhB
0HsAn2gliMht+4pqGbFl1FrLWenol5xR
=wWhQ
-----END PGP SIGNATURE-----