[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: env+nice, one bug fix, two test corrections
From: |
Jim Meyering |
Subject: |
Re: env+nice, one bug fix, two test corrections |
Date: |
Tue, 27 Oct 2009 08:24:53 +0100 |
Eric Blake wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>
>> Looks good, but there was one failure:
>>
>> + test xfail = xfail
>> ++ env sh -c '\c=d echo fail'
>> sh: c=d: command not found
>
> Aargh. Leaving . on the tail of my PATH is getting the better of me during
> testing (even though I like the convenience it provides otherwise). Maybe we
I'm surprised you leave "." anywhere in your PATH.
I don't trust myself not to make typos.
With "." in PATH, all it takes is a predictable typo while I'm cd'd to
an insecure directory (albeit on a cracked or multi-user system, which
is rare), and I'm trojaned.
> should modify tests/test-lib.sh to sanitize dot (or more generally, all non-
> absolute entries) out of PATH? Findutils did something similar, skipping
> various tests if PATH contains any relative entries. And autotest
> intentionally rewrites all relative entries in PATH to their absolute
> counterpart in relation to the directory where the testsuite was started, in
> order to allow the testsuite can change directory at will without picking up
> path search effects.
>
> At any rate, the fix is just as before, so I'll fold this in (and test without
> dot in my PATH):
>
> - test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1
> + test "x$(PATH=$PATH: env sh -c '\c=d echo fail')" = xpass || fail=1
- env+nice, one bug fix, two test corrections, Jim Meyering, 2009/10/26
- Re: env+nice, one bug fix, two test corrections, Eric Blake, 2009/10/26
- Re: env+nice, one bug fix, two test corrections, Eric Blake, 2009/10/26
- Re: env+nice, one bug fix, two test corrections, Jim Meyering, 2009/10/26
- Re: env+nice, one bug fix, two test corrections, Eric Blake, 2009/10/26
- Re: env+nice, one bug fix, two test corrections, Jim Meyering, 2009/10/26
- Re: env+nice, one bug fix, two test corrections, Eric Blake, 2009/10/26
- Re: env+nice, one bug fix, two test corrections,
Jim Meyering <=
Re: env+nice, one bug fix, two test corrections, Eric Blake, 2009/10/28
- Re: env+nice, one bug fix, two test corrections, Jim Meyering, 2009/10/28
- Re: env+nice, one bug fix, two test corrections, Eric Blake, 2009/10/28
- Re: env+nice, one bug fix, two test corrections, Pádraig Brady, 2009/10/28
- RE: env+nice, one bug fix, two test corrections, Voelker, Bernhard, 2009/10/29
- Re: env+nice, one bug fix, two test corrections, Pádraig Brady, 2009/10/29
- RE: env+nice, one bug fix, two test corrections, Voelker, Bernhard, 2009/10/29