Re: pre-release test: GNU Datamash 1.7.74-c040

[Erik Auerswald]

Hey Tim,

On Mon, Jul 04, 2022 at 09:47:59PM +0000, Tim Rice wrote:
> 
> > Not really a problem, but I wonder if the copyright year should be
> > updated to 2022?
> 
> Ah yeah, sure thing.
> 
> I tweaked the rest of the copyright/author notice from `--version`
> too. Hopefully it's now consistent with [1].

It seems that you just tweaked the notice contents, but did not update
the year, at least not in the git master branch:

    $ ./datamash --version | head -n2
    datamash (GNU datamash) 1.7.34-4187
    Copyright (C) 2021 Assaf Gordon and Tim Rice
                  ^^^^

Looking at the git commit log, there might be some automatic copyright
year adjustment mechanism available:

    $ git log -n1 02a693a81a6b134833e75afeebb103924c3e2014
    commit 02a693a81a6b134833e75afeebb103924c3e2014
    Author: Assaf Gordon <assafgordon@gmail.com>
    Date:   Tue Jan 5 17:44:01 2021 -0700

        maint: update copyright year

        Run "make update-copyright" and then:
        * gnulib: Update to latest.
        * tests/init.sh, bootstrap: Update to latest from gnulib.
        * m4/.gitignore: Add gnulib updates.

This seems to work only partially, perhaps because it only looks for
'Assaf Gordon', but it prints messages when it cannot adjust the copyright
year of a file:

    […]
    bootstrap: warning: copyright statement not found
    m4/ax_c_long_long.m4: warning: copyright statement not found
    man/help2man: warning: copyright statement not found
    src/die.h: warning: copyright statement not found
    src/key-compare.c: warning: copyright statement not found
    src/key-compare.h: warning: copyright statement not found
    tests/Coreutils.pm: warning: copyright statement not found
    tests/CuSkip.pm: warning: copyright statement not found
    tests/CuTmpdir.pm: warning: copyright statement not found
    tests/datamash-io-errors-cheap.sh: warning: copyright statement not found
    tests/init.sh: warning: copyright statement not found

I think this is mostly fine, of the above, only the test script
tests/datamash-io-errors-cheap.sh written by me would need copyright year
adjustments in the future, I think.  But then I do not really understand
GNU copyright notice arcana...

> [1] https://www.gnu.org/prep/maintain/maintain.html#Copyright-Notices

Br,
Erik