bug#37518: [PATCH] Search upward from current dir for the default TAGS file

[Lars Ingebrigtsen]

Hong Xu <hong@topbug.net> writes:

> * lisp/progmodes/etags.el (tags--find-default-tags-dir)
> (tags--find-default-tags-dir-impl, visit-tags-table): Search
> upward from current dir for the default TAGS file

Sounds good.  Some minor comments:

[...]

>  +(defun tags--find-default-tags-dir-impl (current-dir)

We don't really call functions for "-impl" or the like -- as this
recurses upwards, what about calling it something more descriptive like
`tags--find-default-tags-dir-recursively'?

[...]

> +(defun tags--find-default-tags-dir ()
> +  "Find the directory that hosts the default TAGS file.
> +It is the first directory that contains a file named TAGS encountered
> +searching upward from `default-directory'."
> +  (let ((default-tag-dir
> +          (tags--find-default-tags-dir-impl default-directory)))
> +    (if default-tag-dir
> +        default-tag-dir
> +      default-directory)))

This is basically

(or (tags--find-default-tags-dir-impl default-directory)
    default-directory)

so I don't think this intermediary function is needed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no