bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#37518: [PATCH] Search upward from current dir for the default TAGS f


From: Hong Xu
Subject: bug#37518: [PATCH] Search upward from current dir for the default TAGS file
Date: Sun, 6 Oct 2019 21:48:52 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

Thanks. I've attached an updated patch below.

On 10/6/19 9:19 PM, Lars Ingebrigtsen wrote:

  +(defun tags--find-default-tags-dir-impl (current-dir)

We don't really call functions for "-impl" or the like -- as this
recurses upwards, what about calling it something more descriptive like
`tags--find-default-tags-dir-recursively'?

Makes sense.



This is basically

(or (tags--find-default-tags-dir-impl default-directory)
     default-directory)

so I don't think this intermediary function is needed.

How could I forget the magical "or" :)

Attachment: 0001-Search-upward-from-current-dir-for-the-default-TAGS-.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]