Could you clarify the reason for the first patch? Did you have any test
failures (on Ubuntu 20.04.1?) with the current test code because of the
"random" filesystem traversal order? Thanks!
The original code *did* already fix the file order in the test where it
actually mattered:
'xref-matches-in-directory-finds-some-for-bar'. Note that no other test
actually involve
locations from multiple files in a way that is dependent on the order.
The patch does not serve any actual utility except for code hygiene: it
reduces a bit
of trivial code duplication. Feel free to ignore it. (But in case you do
add tests for
'xref-file-name-display' being 'relative', please make sure you write
the tests in a way
that makes it independent from the filesystem traversal order.)
Tobias