bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root

[Dmitry Gutov]

Version: 28.1

Hi Tobias,

On 27.12.2020 08:55, Tobias Rittweiler wrote:

> Thank you. I tested the patch and it works fine.
>
> Some comments on the patch itself:
>
> 1. 'xref--project-root' returns a project root if 'project-root' is fboundp.
>      Otherwise it returns a *list* of roots.
>
> 2. And in the second case, 'xref-backend-references' conses that list
>      of roots to the list of external roots. I.e. it constructs an 
> improper list
>      which it then passes to 'mapcan'. This is a bug, isn't it?
>
> 3. 'xref-expanded-seach-root` mispells "search"

Thanks for the comments, I fixed them now.

Also I've simplified the change closer to your original code. If 
anything, that made satisfying the tests easier.

Pushed as 13b59c690a.

That code also doesn't consider the "external roots", I figured it would 
be better to keep the group names unique.

But we can revisit that later, if you or others do find those external 
long file names annoying (let me know). For now, closing.