bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins)

[Michael Heerdegen]

Robert Irelan <rirelan@gmail.com> writes:

>     (defun +ivy--always-return-zero-exit-code-a (fn &rest args)
>       (let ((process-exit-status-orig
>              (symbol-function 'process-exit-status)))
>         (cl-letf* (((symbol-function 'process-exit-status)
>                     (lambda (_proc)
>                       (let ((code (funcall process-exit-status-orig proc)))
>                         (if (= code 2) 0 code)))))
>           (apply fn args)))

You didn't touch what I meant: the variable `proc' is free in your
lambda.  There is only an argument with the similar name `_prog'.  So
that code still looks broken.

Michael.