bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins)

[Stefan Kangas]

Robert Irelan <rirelan@gmail.com> writes:

>     (defun +ivy--always-return-zero-exit-code-a (fn &rest args)
>       (let ((process-exit-status-orig
>              (symbol-function 'process-exit-status)))
>         (cl-letf* (((symbol-function 'process-exit-status)
>                     (lambda (_proc)
>                       (let ((code (funcall process-exit-status-orig _proc)))
>                         (if (= code 2) 0 code)))))
>           (apply fn args)))
>     (advice-add #'counsel-rg :around #'+ivy--always-return-zero-exit-code-a)

Thanks, copying in Andrea here.

> On Tue, Oct 12, 2021 at 3:35 PM Stefan Kangas <stefan@marxist.se> wrote:
>
>  Robert Irelan <rirelan@gmail.com> writes:
>
>  > Ah, I see what you mean. I get the same error when I fix the free
>  > variables in the lambda.
>
>  Could you provide a fixed recipe for this bug?