[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45999: 28.0.50; repeat does not work when saving files modified outs
From: |
Lars Ingebrigtsen |
Subject: |
bug#45999: 28.0.50; repeat does not work when saving files modified outside emacs |
Date: |
Mon, 11 Jul 2022 14:55:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I guess a way to fix this would be to introduce a blocklist (containing
> minibuffer-exit/self-insert-command/etc/etc), but I'm not sure how much
> etc this would be. Or perhaps there's a different way around this.
I tried various approaches, but none seemed to work in a satisfactory
way -- adding a variable to inhibit recording last-repeatable-command
didn't work well, because of how it's set from command_loop_1, and a
blocklist just seemed odd.
But the main problem here is that yes-or-no-p now overwrites
last-repeatable-command with exit-minibuffer, and that's a regression at
least, so I've fixed this specific problem. But I'm still not sure
whether it should be fixed in a more general way, and perhaps a
blocklist is the way to go, anyway... but the reason I didn't do that
is because self-insert-command would have to be on that list for
yes-or-no-p to not override `repeat', and that's a behavioural change.
So I went with the easy fix.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#45999: 28.0.50; repeat does not work when saving files modified outside emacs,
Lars Ingebrigtsen <=