bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path

[Eli Zaretskii]

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: artscan@list.ru,  monnier@iro.umontreal.ca,  63757@debbugs.gnu.org
> Date: Sun, 04 Jun 2023 11:39:53 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Is that a reverse diff or something?  The code we have now already
> > does sort the list...
> 
> No, the current code passes a non-nil NOSORT flag to `directory-files',
> which inhibits sorting?

I'm confused.  The code which the patch adds, viz.:

>  (defun package--get-activatable-pkg (pkg-name)
>    ;; Is "activatable" a word?
> -  (let ((pkg-descs (cdr (assq pkg-name package-alist))))
> +  (let ((pkg-descs (sort (cdr (assq pkg-name package-alist))
> +                         (lambda (p1 p2)
> +                           (let ((v1 (package-desc-version p1))
> +                                 (v2 (package-desc-version p2)))
> +                             (or
> +                              ;; Prefer source packages.
> +                              (eq (package-desc-kind p1) 'vc)
> +                              (not (eq (package-desc-kind p2) 'vc))
> +                              ;; Prefer builtin packages.
> +                              (package-disabled-p p1 v1)
> +                              (not (package-disabled-p p2 v2))))))))
>      ;; Check if PACKAGE is available in `package-alist'.

is already in the version of package.el on the emacs-29 branch.  And
the code which the patch removes, viz.:

>      ;; Check if PACKAGE is available in `package-alist'.
>      (while
>          (when pkg-descs
>            (let ((available-version (package-desc-version (car pkg-descs))))
> -            (or (package-disabled-p pkg-name available-version)
> -                ;; Prefer a builtin package.
> -                (package-built-in-p pkg-name available-version))))
> +            (package-disabled-p pkg-name available-version)))
>        (setq pkg-descs (cdr pkg-descs)))
>      (car pkg-descs)))

is already removed on the emacs-29 branch.

What am I missing here?