bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path

[Eli Zaretskii]

> From: Евгений Бойков <artscan@list.ru>
> Date: Mon, 5 Jun 2023 00:03:48 +1000
> Cc: Eli Zaretskii <eliz@gnu.org>, monnier@iro.umontreal.ca, 
> 63757@debbugs.gnu.org
> 
> > Done.  Should we close the issue then, or wait for more feedback?
> 
> fa8135f8916 * emacs-29 origin/emacs-29 Revert changes to the order in which 
> package descs are
> loaded
> -      (dolist (pkg-dir (directory-files dir t "\\`[^.]" t))
> +      (dolist (pkg-dir (directory-files dir t "\\`[^.]"))
> 
> it doesn't fix the initial problem: `load-path` and `package-alist` are still 
> broken in my test.
> 
> Test:
> To reproduce the case we need emacs 29.0.91 + fa8135f8916 fix  and
>     ~/.emacs.d/elpa/go-mode-20170726.555/...
>     ~/.emacs.d/elpa/go-mode-20220114.2239/...
> Run `emacs -Q` and `M-x package-initialize`. After that `package-alist` and 
> `load-path` contain the
> 2017 version as the first item in the list (instead of 2022).

I guess we need to reverse the list of directories, since
directory-files sorts using string-lessp as the predicate?