bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate.

[Morgan Smith]

Eli Zaretskii <eliz@gnu.org> writes:

>
> Sorry, no, it isn't obvious to me.  So please do provide a complete
> recipe for reproducing the problem, starting frm "emacs -Q".
>
> Thanks.

I apologize for my assumption.

emacs -Q
(setopt completion-auto-help 'visible)
(debug-on-entry 'ding) ;; just so we know when it dings

`M-x eshell` then spam TAB until the completion buffer pops up.  Now
type in enough to select a unique completion.  I'm completing
`eshell-command` so I'll make the minibuffer look like 'eshell-comman'.

Now press one final TAB to select the only available completion.  It
should ding.

Obviously it shouldn't ding in that situation since it is a success.
Also that situation doesn't respect completion-fail-discreetly if you
where to type in a failing completion before the final TAB press.