bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate.

[Eli Zaretskii]

> From: Morgan Smith <Morgan.J.Smith@outlook.com>
> Cc: 63913@debbugs.gnu.org
> Date: Mon, 05 Jun 2023 15:09:02 -0400
> 
> emacs -Q
> (setopt completion-auto-help 'visible)
> (debug-on-entry 'ding) ;; just so we know when it dings
> 
> `M-x eshell` then spam TAB until the completion buffer pops up.  Now
> type in enough to select a unique completion.  I'm completing
> `eshell-command` so I'll make the minibuffer look like 'eshell-comman'.
> 
> Now press one final TAB to select the only available completion.  It
> should ding.

I cannot reproduce this, in the latest build from the emacs-29 branch
(what will soon become Emacs 29.1).  In which version of Emacs do you
see this, and on what OS?

> Also that situation doesn't respect completion-fail-discreetly if you
> where to type in a failing completion before the final TAB press.

Recipe, please.