bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#64242: [PATCH] Fix VC package build when there is no docs dir


From: Eli Zaretskii
Subject: bug#64242: [PATCH] Fix VC package build when there is no docs dir
Date: Sat, 24 Jun 2023 13:43:09 +0300

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: 64242@debbugs.gnu.org,  Daniel Semyonov <daniel@dsemy.com>
> Date: Sat, 24 Jun 2023 10:24:47 +0000
> 
> Regarding Daniel's patch, I don't believe we need `file-name-directory'
> at all, the variable `docs-directory' is just passed to makeinfo -I, and to
> my knowledge it should make a difference if the argument ends with a
> directory delimiter or not.

Are you thinking about directory-file-name instead of
file-name-directory?  The latter returns the parent directory of its
argument, it doesn't affect the trailing slash.  The FILE argument
passed to package-vc--build-documentation is a file, not a directory,
so the file-name-directory call seems justified if we want to pass the
directory to makeinfo.

Or what am I missing?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]