bug#64242: [PATCH] Fix VC package build when there is no docs dir

[Philip Kaludercic]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: 64242@debbugs.gnu.org,  Daniel Semyonov <daniel@dsemy.com>
>> Date: Sat, 24 Jun 2023 10:24:47 +0000
>> 
>> Regarding Daniel's patch, I don't believe we need `file-name-directory'
>> at all, the variable `docs-directory' is just passed to makeinfo -I, and to
>> my knowledge it should make a difference if the argument ends with a
>> directory delimiter or not.
>
> Are you thinking about directory-file-name instead of
> file-name-directory?  

Eh, yes of course I didn't try the patch and expected that to fail.

>                       The latter returns the parent directory of its
> argument, it doesn't affect the trailing slash.  The FILE argument
> passed to package-vc--build-documentation is a file, not a directory,
> so the file-name-directory call seems justified if we want to pass the
> directory to makeinfo.

Right, my bad.

> Or what am I missing?

No, it is all my fault.  I'll try the patch our and if it all works I'll
push it to emacs-29.  Ok?

-- 
Philip Kaludercic