bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer

[Sean Whitton]

Hello,

On Fri 08 Dec 2023 at 08:28am +02, Eli Zaretskii wrote:

>> Cc: 67661@debbugs.gnu.org
>> From: Sean Whitton <spwhitton@spwhitton.name>
>> Date: Thu, 07 Dec 2023 22:04:18 +0000
>>
>> Hello,
>>
>> On Thu 07 Dec 2023 at 07:28pm +02, Juri Linkov wrote:
>>
>> >> 1. emacs -q
>> >> 2. (setopt icomplete-in-buffer t)
>> >> 3. M-x icomplete-mode
>> >> 4. M-x eshell
>> >> 5. try to tab-complete something where there is more than one possible
>> >>    completion, e.g. ls<TAB> in a directory with many files.
>> >>
>> >> Previously you would get the icomplete in buffer completion.
>> >> Now, additionally, *Completions* pops up, but it doesn't make sense to
>> >> have both.
>> >
>> > It's possible to hide *Completions* when icomplete-mode is enabled,
>> > but I'm not sure if everyone will like this.  For example,
>> > I'm using both icomplete-mode and the *Completions* buffer
>> > at the same time in the minibuffer.  And in a regular buffer
>> > we should keep for users the ability to pop up *Completions*
>> > in addition to in-buffer completions.
>> >
>> > Maybe the best solution would be to use something like
>> > in completion-preview-mode where you can use in-buffer
>> > completions and still be able to type M-C-i to pop up
>> > the *Completions* buffer.
>>
>> This is a regression though, right?  It didn't use to pop up.
>
> Once again: it did.  The *Completions* buffer always popped up the
> second time you type TAB.  The problem here is that the first TAB
> doesn't show the in-buffer completion. _That_ is the regression we
> should try fixing.

Right, that's what I meant.

-- 
Sean Whitton