[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not pr
From: |
Eli Zaretskii |
Subject: |
bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input |
Date: |
Thu, 04 Jul 2024 15:50:56 +0300 |
> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: Eshel Yaron <me@eshelyaron.com>, kickingvegas@gmail.com,
> 71927@debbugs.gnu.org, basil@contovou.net, jpw@gnu.org,
> juri@linkov.net
> Date: Thu, 04 Jul 2024 12:06:40 +0200
>
> >> FWIW, AFAICT everything is working correctly, it's just that the
> >> "Operation finished" message hides the prompt. ibuffer-do-isearch
> >> should tell define-ibuffer-op not to display that message, somehow.
> >
> > I don't see how this could be considered "correct": the "Operation
> > finished" message is supposed to be shown only after the Isearch is
> > finished in all the marked buffer, not before. It looks like we need
> > a function that will not return until all the buffers where searched,
> > because that's what define-ibuffer-op expects. Don't you agree?
>
> The attached patch appears to DTRT, but I only tested it briefly.
Thanks, but does it really make sense to change define-ibuffer-op to
fix the functions which (evidently) use it incorrectly? I think the
fix needs to be in the same place where the bug is.
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Charles Choi, 2024/07/03
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Juri Linkov, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eshel Yaron, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input,
Eli Zaretskii <=
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Juri Linkov, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eshel Yaron, 2024/07/07
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Juri Linkov, 2024/07/07