[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not pr
From: |
Juri Linkov |
Subject: |
bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input |
Date: |
Thu, 04 Jul 2024 19:04:42 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) |
>>> FWIW, AFAICT everything is working correctly, it's just that the
>>> "Operation finished" message hides the prompt. ibuffer-do-isearch
>>> should tell define-ibuffer-op not to display that message, somehow.
>>
>> I don't see how this could be considered "correct": the "Operation
>> finished" message is supposed to be shown only after the Isearch is
>> finished in all the marked buffer, not before. It looks like we need
>> a function that will not return until all the buffers where searched,
>> because that's what define-ibuffer-op expects. Don't you agree?
It intentionally uses 'no-recursive-edit' set to t, so ibuffer-do-isearch
correctly exits immediately while leaving isearch-mode enabled.
> The attached patch appears to DTRT, but I only tested it briefly.
> ...
> (define-ibuffer-op ibuffer-do-isearch ()
> "Perform a `isearch-forward' in marked buffers."
> (:interactive ()
> - :opstring "searched in"
> + :no-opstring t
Thanks for the patch. I confirm this is the right thing to do.
Maybe instead of :no-opstring would be better to use some special value
like :opstring 'no? But I'm not sure if this is better than :no-opstring.
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Charles Choi, 2024/07/03
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Juri Linkov, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eshel Yaron, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input,
Juri Linkov <=
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Stephen Berman, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/04
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eshel Yaron, 2024/07/07
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Juri Linkov, 2024/07/07
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eli Zaretskii, 2024/07/12
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Eshel Yaron, 2024/07/12
- bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input, Charles Choi, 2024/07/12