[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell
From: |
Eli Zaretskii |
Subject: |
bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed |
Date: |
Thu, 11 Jul 2024 07:34:16 +0300 |
> Date: Wed, 10 Jul 2024 12:55:25 -0700
> Cc: 72018@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 7/10/2024 10:34 AM, Eli Zaretskii wrote:
> >> Date: Wed, 10 Jul 2024 09:16:11 -0700
> >> Cc: 72018@debbugs.gnu.org
> >> From: Jim Porter <jporterbugs@gmail.com>
> >>
> >> We want to reset the prompt (this just emits a new command prompt) for
> >> foreground commands, but for background commands, we don't need to do
> >> anything. Would it be clearer if I inverted the wording in the comment,
> >> like, "Don't reset the prompt if the command we just aborted was in the
> >> background"?
> >
> > I think these subtleties just warrant more detailed comments, and then
> > we'll be fine.
>
> How about this?
LGTM, thanks.
This is okay for emacs-30.