PSPP-BUG: [bug #20910] GUI becomes extremely slow after executing syntax which doesn't read the data

[John Darrington]

Follow-up Comment #5, bug #20910 (project pspp):

> Is it what you had in mind?

More or less.  Here's some additional comments:

1. Consider renaming lazy_casereader_destroy.  It doesn't destroy the
casereader. It (conditionally) destroys the status, (and returns some state
from it).  Maybe just call it lazy_status_destroy or
lazy_casereader_is_instantiated ?

2. It would follow the OO paradigm more closely if there was a struct called
struct lazy_casereader, which inhereted from an ordinary casereader.  It would
need to contain extra state (what's currently in struct lazy_status) and would
need one extra method (currently performed by lazy_status_destroy).  That way,
we don't need a seperate lazy_status at all, so would make execute_syntax
simpler.  On the down side it's more work, and means exposing some of the
casereader internals so perhaps it's not worth the effort.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?20910>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/