[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: match_nodes() in covariance-matrix.c

From: Ben Pfaff
Subject: PSPP-BUG: match_nodes() in covariance-matrix.c
Date: Sat, 17 Jan 2009 23:21:01 -0800
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

Hi Jason.  It looks to me that some of the logic in match_nodes()
in covariance-matrix.c is reversed.  In particular,
compare_values_short() returns nonzero if values differ, which it
seems to me should make match_nodes() return nonzero also, but in
fact it makes match_nodes() return 0.  So I think that each
"compare_values_short(...)" should really be

Is my analysis correct?  (I don't understand anything above the
level of this single function, so I could be way off.)
"Term, holidays, term, holidays, till we leave school,
 and then work, work, work till we die."
C. S. Lewis

reply via email to

[Prev in Thread] Current Thread [Next in Thread]