[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PSPP-BUG: match_nodes() in covariance-matrix.c

From: Ben Pfaff
Subject: Re: PSPP-BUG: match_nodes() in covariance-matrix.c
Date: Mon, 19 Jan 2009 21:30:38 -0800
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

Jason Stover <address@hidden> writes:

> On Sat, Jan 17, 2009 at 11:21:01PM -0800, Ben Pfaff wrote:
>> Hi Jason.  It looks to me that some of the logic in match_nodes()
>> in covariance-matrix.c is reversed.  In particular,
>> compare_values_short() returns nonzero if values differ, which it
>> seems to me should make match_nodes() return nonzero also, but in
>> fact it makes match_nodes() return 0.  So I think that each
>> "compare_values_short(...)" should really be
>> "!compare_values_short(...)".
>> Is my analysis correct?  (I don't understand anything above the
>> level of this single function, so I could be way off.)
> You're right. I just committed a fix.

Thanks, it looks good.
"There's only one thing that will make them stop hating you.
 And that's being so good at what you do that they can't ignore you.
 I told them you were the best.  Now you damn well better be."
--Orson Scott Card, _Ender's Game_

reply via email to

[Prev in Thread] Current Thread [Next in Thread]