[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [bug #39252] Changing variable type in GUI clears data

From: Ben Pfaff
Subject: PSPP-BUG: [bug #39252] Changing variable type in GUI clears data
Date: Fri, 21 Jun 2013 04:46:27 +0000
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.12) Gecko/20100101 Firefox/10.0.12 Iceweasel/10.0.12

Follow-up Comment #4, bug #39252 (project pspp):

Thank you for working on this.  I think that this will work.

The more general var_changed() callback is nicer, I think.  Good idea.

This functionality is related to the ALTER TYPE command, which is
unimplemented.  I don't know whether implementing ALTER TYPE would help.

I see some memory leaks: some var_set_*() functions unconditionally clone the
variable but only conditionally pass it to dict_var_changed().

Each call to dict_var_changed() passes exactly one VAR_TRAIT_*.  If you don't
expect that to change, then VAR_TRAIT_* does not need to be a bit-mask.

I think that the new version of var_clone() is a little harder to understand. 
It would not need to change, if one added a helper function that called
var_clone() if its argument variable's dictionary had a nonnull var_changed
callback and simply returns NULL otherwise, and then each var_set_*() used
that instead of calling var_clone() directly.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]