[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [bug #39252] Changing variable type in GUI clears data

From: John Darrington
Subject: PSPP-BUG: [bug #39252] Changing variable type in GUI clears data
Date: Fri, 21 Jun 2013 06:59:54 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20100101 Firefox/21.0

Follow-up Comment #5, bug #39252 (project pspp):

> I see some memory leaks: some var_set_*() functions unconditionally clone
the variable but only conditionally pass it to dict_var_changed(). 

I thought I had checked that.  I'll take another look.

> Each call to dict_var_changed() passes exactly one VAR_TRAIT_. If you don't
expect that to change, then VAR_TRAIT_ does not need to be a bit-mask. 

You are right.  I can foresee a time when the changes could be aggregated and
one signal instead of several emitted.   ALTER TYPE might also benefit from
being able to pass several TRAITS concurrently.

I'll rework this following your suggestions, and send it out for a second
review.  I'll try to do them as separate changes to make the review easier.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]