bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: about gawk |& operator and getline on HPUX11


From: Paul Eggert
Subject: Re: about gawk |& operator and getline on HPUX11
Date: Fri, 24 May 2002 10:53:19 -0700 (PDT)

> From: Stepan Kasal <address@hidden>
> User-Agent: Mutt/1.2.5.1i

> -#define DEFBLKSIZE   (stb->st_blksize ? stb->st_blksize : BUFSIZ)
> +                     /*
> +                      * 100k must be enough for everybody,
> +                      * bigger number means probably a bug in fstat()
> +                      */
> +#define MAXBLKSIZE   102400
> +#define DEFBLKSIZE   (stb->st_blksize > 0 && stb->st_blksize <= MAXBLKSIZE \

It is reasonable to check that st_blksize is positive, but I'm not
sure that it is a good idea to put an arbitrary limit on it.  GNU
software shouldn't have arbitrary limits.

Wouldn't it be better to fix Autoconf's AC_STRUCT_ST_BLKSIZE so that
it reports that st_blksize does not exist on the buggy platforms?

What exactly is the bug that ARPA Transport patch PHNE_26771 fixes?
Is this a bug in the runtime library, or a bug in the headers?  Is
there a reliable way to detect whether the bug exists, preferably at
compile-time?  If we can find out what it is, then we should be able
to write a test that detects it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]