Re: I believe there is a logic error in gas/config/tc-mips.c

[Daniel Jacobowitz]

See the binutils@ list, where this feature is presently being
discussed.  Right now it is only supported for EMBEDDED_PIC.

On Wed, Feb 26, 2003 at 06:12:05PM -0800, Sean McNeil wrote:
> The following appears to be a logic error that causes improper blocking
> of valid reloc usage on symbols defined as .globl.  The comment
> preceding the code supports the belief that it is a logic error:
> 
> diff -c -3 -p -r1.193 tc-mips.c
> *** gas/config/tc-mips.c        21 Feb 2003 10:28:27 -0000      1.193
> --- gas/config/tc-mips.c        27 Feb 2003 02:08:49 -0000
> *************** tc_gen_reloc (section, fixp)
> *** 13380,13386 ****
>     if ((OUTPUT_FLAVOR == bfd_target_ecoff_flavour
>          || OUTPUT_FLAVOR == bfd_target_elf_flavour)
>         && code == BFD_RELOC_16_PCREL_S2
> !       && mips_pic != EMBEDDED_PIC)
>       reloc->howto = NULL;
>     else
>       reloc->howto = bfd_reloc_type_lookup (stdoutput, code);
> --- 13380,13386 ----
>     if ((OUTPUT_FLAVOR == bfd_target_ecoff_flavour
>          || OUTPUT_FLAVOR == bfd_target_elf_flavour)
>         && code == BFD_RELOC_16_PCREL_S2
> !       && mips_pic == EMBEDDED_PIC)
>       reloc->howto = NULL;
>     else
>       reloc->howto = bfd_reloc_type_lookup (stdoutput, code);
> 
> 
> 
> 
> _______________________________________________
> Bug-gnu-utils mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-gnu-utils
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer