Re: I believe there is a logic error in gas/config/tc-mips.c

[Sean McNeil]

I guess I am just reading the comment incorrectly.  I hope this can get
resolved as I have a good deal of assembly code that does branches to
global symbols.  I can't understand how it could be disallowed by the
MIPS standard.  This code is used by both GNU and Diab tools.

Sean

On Wed, 2003-02-26 at 20:07, Sean McNeil wrote:
> That's just it.  The code is checking for anything other than
> EMBEDDED_PIC, not the other way around.  It is a check to make sure that
> in the EMBEDDED_PIC case the Cygwin patch did it's job.
> 
> Sean
> 
> On Wed, 2003-02-26 at 19:16, Daniel Jacobowitz wrote:
> > See the binutils@ list, where this feature is presently being
> > discussed.  Right now it is only supported for EMBEDDED_PIC.
> > 
> > On Wed, Feb 26, 2003 at 06:12:05PM -0800, Sean McNeil wrote:
> > > The following appears to be a logic error that causes improper blocking
> > > of valid reloc usage on symbols defined as .globl.  The comment
> > > preceding the code supports the belief that it is a logic error:
> > > 
> > > diff -c -3 -p -r1.193 tc-mips.c
> > > *** gas/config/tc-mips.c        21 Feb 2003 10:28:27 -0000      1.193
> > > --- gas/config/tc-mips.c        27 Feb 2003 02:08:49 -0000
> > > *************** tc_gen_reloc (section, fixp)
> > > *** 13380,13386 ****
> > >     if ((OUTPUT_FLAVOR == bfd_target_ecoff_flavour
> > >          || OUTPUT_FLAVOR == bfd_target_elf_flavour)
> > >         && code == BFD_RELOC_16_PCREL_S2
> > > !       && mips_pic != EMBEDDED_PIC)
> > >       reloc->howto = NULL;
> > >     else
> > >       reloc->howto = bfd_reloc_type_lookup (stdoutput, code);
> > > --- 13380,13386 ----
> > >     if ((OUTPUT_FLAVOR == bfd_target_ecoff_flavour
> > >          || OUTPUT_FLAVOR == bfd_target_elf_flavour)
> > >         && code == BFD_RELOC_16_PCREL_S2
> > > !       && mips_pic == EMBEDDED_PIC)
> > >       reloc->howto = NULL;
> > >     else
> > >       reloc->howto = bfd_reloc_type_lookup (stdoutput, code);
> > > 
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > Bug-gnu-utils mailing list
> > > address@hidden
> > > http://mail.gnu.org/mailman/listinfo/bug-gnu-utils
> > >