Re: locale-dependent assertion failure in gawk 3.1.5

[Andrew J. Schorr]

On Fri, Jul 07, 2006 at 06:45:30PM +0200, Jürgen Kahrs wrote:
> Andrew J. Schorr wrote:
> 
> > The attached patch seems to fix the problem, but I'm still not
> > sure why there was no error on my 64-bit linux opteron system,
> > and I'm not 100% confident that this fix is OK...
> 
> Have a look at what Lee Haywood posted here on 2006-04-27
> under the subject
> 
>   gawk multi-byte support bugs, assertion bug and fix.

I think that patch to mk_number is incorrect.  The "getnode" macro
should not be providing a NODE with non-NULL wstptr.  That's why
the code to set that field is inside GAWKDEBUG, and that's where
it belongs.  The earlier patch is just masking the problem, and
leaving a memory leak.

The proper fix is to make sure that freenode does not add a NODE
with non-NULL wstptr to the free list.  That being said, my patch
does not fix the test case reported in that message (but it probably
does fix the assertion failure, although no test case was provided
for that).

But I think the combination of my earlier patch with the additional
attached patch, which is based on

http://lists.nongnu.org/archive/html/bug-gnu-utils/2006-03/msg00004.html

should fix all of these problems.

But this all raises a question of what the canonically proper way
is to clear the wstptr setting.  Perhaps a macro or function would
be appropriate...

Regards,
Andy

sub_common.patch
Description: Text document