Re: locale-dependent assertion failure in gawk 3.1.5

[Andrew J. Schorr]

On Fri, Jul 07, 2006 at 04:57:28PM -0400, Andrew J. Schorr wrote:
> But this all raises a question of what the canonically proper way
> is to clear the wstptr setting.  Perhaps a macro or function would
> be appropriate...

So does the attached patch make sense?  Or would it be better to
use a macro to avoid the performance hit of a function call?
I think it's a bit cleaner/safer not to repeat the same code
in multiple places...

Given that NODE is a union, I'm not clear on whether it's OK to
test the wstptr value if the WSTRCUR flag is not set.  I guess
one has to assume that wstptr may contain random garbage if WSTRCUR
is not set; is that the correct approach?  Or would it be safe to
assume that if STRCUR is set, then
   (wstptr != NULL) <==> ((flags & WSTRCUR) != 0)?

Regards,
Andy

wstptr.patch
Description: Text document