RE: [Bug-gnubg] Proposed patches to the gnubg sources

[macherius]

Øystein Johansen wrote:

> My solution is to change some lines in pyconfig.h
> 
> C:\Python23\include>diff pyconfig.h pyconfig.h~
> 31d30
> < #ifndef HAVE_LIMITS_H
> 33d31
> < #endif
> 
> Done!

jon_kinsey wrote:

>> * board3d/ drawboard.c font3d.cpp graph.c gtkcolour.c matrix.c misc3d.c
model.c shadow.c
>> widget3d.c
>> - include windows.h before GL headers, otherwise definitions in the Open
GL headers are
>> missing and yieding compiler errors
>
> A better(?) fix is to add #include <windows.h> to the gl.h microsoft
include file - it should > be in there and all the other gl.h files I've
come across are fine.

You are the maintainers here, but I don't like the idea to change third
party headers to compile just any open souce. Gnubg was harder to compile
than anything else I ported so far, and that included some weird stuff like
gcc for Sinix on MIPS. Checkout, compile and face dozens of unnecessary
warnings and errors. Is it really required to have such oddities, in
particular where the patches to gnubg are there, and come at no cost?

Ingo