bug-gnubg
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnubg] Relational dBs issues


From: Massimiliano Maini
Subject: Re: [Bug-gnubg] Relational dBs issues
Date: Mon, 25 Feb 2008 10:26:08 +0100


Jonathan Kinsey <address@hidden> wrote on 24/02/2008 23:39:19:

> Massimiliano Maini wrote:
> >
> > the relational dB feature looks much better now.
> >
> > A few issues/problems I've encountered up to now:
> >
> > 1- in the "Settings/Options/Database" dialog, when a db is deleted, the
> > "Info"  text is not updated.
>
> Fixed


Confirmed !

> > 2- the possibility to have more dBs is great, but it would be nice to
> > highlight better which dB is currently in
> > use: either each time a match is added we prompt for the dB (if more
> > than one available), either we show
> > the name of the current dB directly in the "Analyse/Relational database"
> > menu (something like
> > "Analyse/Relational database [gnubg.db]")
>
> This would be nice, I think we should have some automatic way to addanalysed
> matches to the database.  Probably needs a bit more thought.

What about an pop-up that appears any time the analysis of a match/session is done,
asking to add the match to the dB ?
Nice to have: a global option like "always add analyzed matched to dB".
 
> > 3- as soon as a match is added to the dB, it becomes impossible to
> > delete the dB from the
> > "Settings/Options/Database" dialog: missing "close file/connection"
> > somewhere ?
>
> Fixed.  Also the old game data should be removed when a duplicate is added.

Confirmed, works fine now.

> Didn't see a problem with leading white space in the query dialog.

Because the issue seems to be with a "trailing empty line" (at the end of the query).
Actually it is impossible to write a query on multiple lines, no resul is returned.

MaX.

P.S.
Other minor warnings:

dbprovider.c:59: warning: 'SQLiteConnect' declared `static' but never defined
dbprovider.c:60: warning: 'SQLiteDisconnect' declared `static' but never defined
dbprovider.c:61: warning: 'SQLiteSelect' declared `static' but never defined
dbprovider.c:62: warning: 'SQLiteUpdateCommand' declared `static' but never defined
dbprovider.c:63: warning: 'SQLiteCommit' declared `static' but never defined


reply via email to

[Prev in Thread] Current Thread [Next in Thread]