bug-gnulib
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: arcfour

From: Paul Eggert
Subject: Re: arcfour
Date: Fri, 14 Oct 2005 16:47:52 -0700
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) 
Simon Josefsson <address@hidden> writes:

> Revised patch below.  Ok to install?

Yes, with one minor nit:

> +      *outbuf++ = *inbuf++ ^
> +     sbox[(0U + sbox[i] + sbox[j]) % ARCFOUR_SBOX_SIZE];

The usual GNU style is to parenthesize and indent right-hand-sides
that cross line boundaries, e.g.,

  *outbuf++ = (*inbuf++
               ^ sbox[(0U + sbox[i] + sbox[j]) % ARCFOUR_SBOX_SIZE]);

Thanks.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]