bug-gnulib
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: arcfour

From: Simon Josefsson
Subject: Re: arcfour
Date: Sat, 15 Oct 2005 20:19:45 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) 
Paul Eggert <address@hidden> writes:

> Simon Josefsson <address@hidden> writes:
>
>> Revised patch below.  Ok to install?
>
> Yes, with one minor nit:
>
>> +      *outbuf++ = *inbuf++ ^
>> +    sbox[(0U + sbox[i] + sbox[j]) % ARCFOUR_SBOX_SIZE];
>
> The usual GNU style is to parenthesize and indent right-hand-sides
> that cross line boundaries, e.g.,
>
>   *outbuf++ = (*inbuf++
>                ^ sbox[(0U + sbox[i] + sbox[j]) % ARCFOUR_SBOX_SIZE]);

Applied and installed, thanks!
reply via email to
[Prev in Thread] Current Thread [Next in Thread]