[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Implementation of fsync for Windows
From: |
Eric Blake |
Subject: |
Re: [PATCH] Implementation of fsync for Windows |
Date: |
Wed, 1 Oct 2008 17:51:23 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
Richard W.M. Jones <rjones <at> redhat.com> writes:
>
> Like the earlier patch, but this relicenses to LGPLv2+, includes
> license text, and assigns everything to the FSF.
Do you have copyright on file for gnulib yet?
> --- a/NEWS
> +++ b/NEWS
> @@ -6,6 +6,8 @@ User visible incompatible changes
>
> Date Modules Changes
>
> +2008-10-01 fsync This function has been implemented for Windows.
> +
NEWS is for incompatible changes. But adding a new module is compatible. I
would drop the NEWS entry.
> +#else /* Windows */
Technically, this is #else /* !Windows */
> +lib/fsync.c
> +m4/fsync.m4
> +
> +Depends-on:
> +unistd
Should this also depend on the errno module?
> +++ b/tests/test-fsync.c
> @@ -0,0 +1,48 @@
...
> +
> +#include <stdio.h>
Whoops. Always include <config.h> first in test cases.
--
Eric Blake
Re: [PATCH] Implementation of fsync for Windows, Richard W.M. Jones, 2008/10/01
Re: [PATCH] Implementation of fsync for Windows, Bruno Haible, 2008/10/01