[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Implementation of fsync for Windows
From: |
Jim Meyering |
Subject: |
Re: [PATCH] Implementation of fsync for Windows |
Date: |
Wed, 01 Oct 2008 20:15:01 +0200 |
Eric Blake <address@hidden> wrote:
> Richard W.M. Jones <rjones <at> redhat.com> writes:
>> Like the earlier patch, but this relicenses to LGPLv2+, includes
>> license text, and assigns everything to the FSF.
Addressing Eric's feedback, and tweaking copyright and a comment,
FYI, this is the incremental I'm about to merge:
diff --git a/NEWS b/NEWS
index 4c6edfe..ef04cf4 100644
--- a/NEWS
+++ b/NEWS
@@ -6,8 +6,6 @@ User visible incompatible changes
Date Modules Changes
-2008-10-01 fsync This function has been implemented for Windows.
-
2008-09-28 sockets When using this module, you now need to link with
$(LIBSOCKET).
diff --git a/lib/fsync.c b/lib/fsync.c
index 3848a69..4a0fe0f 100644
--- a/lib/fsync.c
+++ b/lib/fsync.c
@@ -1,4 +1,4 @@
-/* Emulate fsync on platforms which lack it, primarily Windows and
+/* Emulate fsync on platforms that lack it, primarily Windows and
cross-compilers like MinGW.
This is derived from sqlite3 sources.
@@ -7,8 +7,7 @@
Written by Richard W.M. Jones <rjones.at.redhat.com>
- Copyright (C) 2008
- Free Software Foundation, Inc.
+ Copyright (C) 2008 Free Software Foundation, Inc.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
@@ -20,11 +19,8 @@
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
- You should have received a copy of the GNU Lesser General Public
- License along with the library; if not, write to the Free
- Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
- 02111-1307 USA.
-*/
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <config.h>
#include <unistd.h>
@@ -75,7 +71,7 @@ fsync (int fd)
return 0;
}
-#else /* Windows */
+#else /* !Windows */
#error "This platform lacks fsync function, and Gnulib doesn't provide a
replacement. This is a bug in Gnulib."
diff --git a/tests/test-fsync.c b/tests/test-fsync.c
index fcecf3c..26219da 100644
--- a/tests/test-fsync.c
+++ b/tests/test-fsync.c
@@ -14,6 +14,7 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include <config.h>
#include <stdio.h>
#include <fcntl.h>
#include <unistd.h>
- [PATCH] Implementation of fsync for Windows, Richard W.M. Jones, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Jim Meyering, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Richard W.M. Jones, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Richard W.M. Jones, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Richard W.M. Jones, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Jim Meyering, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Eric Blake, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Jim Meyering, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Bruno Haible, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows,
Jim Meyering <=
- Re: [PATCH] Implementation of fsync for Windows, Jim Meyering, 2008/10/01
- Re: [PATCH] Implementation of fsync for Windows, Richard W.M. Jones, 2008/10/01
Re: [PATCH] Implementation of fsync for Windows, Richard W.M. Jones, 2008/10/01
Re: [PATCH] Implementation of fsync for Windows, Bruno Haible, 2008/10/01