[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnupod] Bug fixes for gnupod.

From: Richard van den Berg
Subject: Re: [Bug-gnupod] Bug fixes for gnupod.
Date: Tue, 31 May 2011 20:55:25 +0200
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv: Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10

Hello Brad,

Thanks for the ffmpeg fixes, they look very useful.

On 30-5-11 22:39 , Brad wrote:
>  printf "%s" "checking for ImageMagick..."
>  convert --version > /dev/null 2>&1
> - if test $? = 0; then
> + if test $? = 1; then

This change is incorrect. Convert returns 0 when it exists. A non-zero
result is expected when it does not exist.

$ convert --version
Version: ImageMagick 6.6.4-0 2010-09-18 Q16 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2010 ImageMagick Studio LLC
Features: OpenMP

$ echo $?
$ notthere --version
-bash: notthere: command not found
$ echo $?

However, the check in configure is informative only. The result is not
used in the perl code of gnupod.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]