[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: [PATCH] trans/fakeroot.c
From: |
Svante Signell |
Subject: |
Re: RFC: [PATCH] trans/fakeroot.c |
Date: |
Tue, 12 May 2015 11:39:19 +0200 |
On Tue, 2015-05-12 at 11:22 +0200, Samuel Thibault wrote:
> Svante Signell, le Tue 12 May 2015 10:00:26 +0200, a écrit :
> > On Tue, 2015-05-12 at 09:42 +0200, Samuel Thibault wrote:
> > > Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit :
> > > > The idea is to limit the openmodes according to the values defined in
> > > > struct netnode and to change the test for overlapping sets.
> > >
> > > In which case is this needed? What happens in that case and how the
> > > patch fixes this?
> >
> > I already supplied a test case. What's up?
>
> Explain what happens.
>
> Only providing a testcase means the reviewer has to
> For instance here, just inventing dumb things, it's just to give an
> example of what I need to see explained to avoid having to spend a few
> hours to understand what's happening: the testcase creates a socket,
Sorry for the confusion: This patch is not about the socket creation
case. It is about the build failure of gnat-4.9 with fakeroot-hurd. two
different bugs!
Re: RFC: [PATCH] trans/fakeroot.c, Samuel Thibault, 2015/05/15