[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 7/7] hurd: fix pushing target on inferior creation
From: |
Simon Marchi |
Subject: |
Re: [PATCHv2 7/7] hurd: fix pushing target on inferior creation |
Date: |
Sat, 30 May 2020 11:01:47 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 2020-05-29 6:04 p.m., Samuel Thibault wrote:
> This fixes creating inferiors, which was broken since 5b6d1e4fa
> ('Multi-target support')
>
> gdb/ChangeLog:
>
> 2020-05-29 Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
> before fork_inferior call. Avoid calling it if target_is_pushed returns
> false.
`returns false` -> `returns true`?
Otherwise, LGTM.
Simon
- [PATCHv2 4/7] hurd: add missing include, (continued)
[PATCHv2 7/7] hurd: fix pushing target on inferior creation, Samuel Thibault, 2020/05/29
- Re: [PATCHv2 7/7] hurd: fix pushing target on inferior creation,
Simon Marchi <=
Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type, Simon Marchi, 2020/05/30
Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type, Samuel Thibault, 2020/05/30