Re: [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls

[Samuel Thibault]

Simon Marchi, le sam. 30 mai 2020 10:57:42 -0400, a ecrit:
> > @@ -1106,12 +1109,12 @@ inf_validate_procs (struct inf *inf)
> >         if (inferior_ptid == ptid_t (inf->pid))
> >           /* This is the first time we're hearing about thread
> >              ids, after a fork-child.  */
> > -         thread_change_ptid (inferior_ptid, ptid);
> > +         thread_change_ptid (gnu_target, inferior_ptid, ptid);
> 
> 
> I think it would have been more straightforward and clean to use 
> `inf->process_target ()`
> (assuming it's the correct thing to do), given that you have access to the 
> appropriate
> inferior everywhere you made changes.

I didn't see a way to access the inferior here (inf is a
gnu-nat.c-specific structure with no link to struct inferior)

> But I also see that you've pretty much replicated what the linux-nat target 
> does

Yes, that seemed simpler to stick along what Linux is currently doing.

Samuel