Re: [PATCH 04/23] mach: Drop some unnecessary vm_param.h includes

[Samuel Thibault]

Applied, thanks!

Sergey Bugaev, le mer. 03 janv. 2024 20:14:37 +0300, a ecrit:
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
> 
> We should try to include vm_param.h less; this statically asserts that
> these files are not possibly using the PAGE_SIZE definition.
> 
> dl-sysdep.c used VM_MAX_ADDRESS for the "loser kludge for vm_map kernel
> bug"; that bug has been fixed and the kludge removed. setup-thread.c has
> been including vm_param.h from the start; I can't see any reason for it.
> 
>  mach/setup-thread.c           | 1 -
>  sysdeps/mach/hurd/dl-sysdep.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/mach/setup-thread.c b/mach/setup-thread.c
> index 72bf1083..1e7f9953 100644
> --- a/mach/setup-thread.c
> +++ b/mach/setup-thread.c
> @@ -19,7 +19,6 @@
>  #include <mach/setup-thread.h>
>  #include <thread_state.h>
>  #include <string.h>
> -#include <mach/machine/vm_param.h>
>  #include <ldsodefs.h>
>  #include "sysdep.h"          /* Defines stack direction.  */
>  
> diff --git a/sysdeps/mach/hurd/dl-sysdep.c b/sysdeps/mach/hurd/dl-sysdep.c
> index d3933bfe..43129a1e 100644
> --- a/sysdeps/mach/hurd/dl-sysdep.c
> +++ b/sysdeps/mach/hurd/dl-sysdep.c
> @@ -32,7 +32,6 @@
>  #include <sysdep.h>
>  #include <argz.h>
>  #include <mach/mig_support.h>
> -#include <mach/machine/vm_param.h>
>  #include "hurdstartup.h"
>  #include <hurd/lookup.h>
>  #include <hurd/auth.h>
> -- 
> 2.43.0
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.