[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] Allow tests to be disabled
From: |
Peter Maydell |
Subject: |
Re: [PATCH 3/4] Allow tests to be disabled |
Date: |
Wed, 17 Jan 2024 17:35:07 +0000 |
On Wed, 17 Jan 2024 at 12:59, Manolo de Medici <manolodemedici@gmail.com> wrote:
>
> tests/qtest/tpm-* compilation is not disabled by disable-tpm,
> for this reason compilation fails on systems that doesn't
> support the linux/bsd TPM api. Fix this by allowing tests
> to be disabled.
This isn't the right way to fix this. Either the tpm test
code has portability issues that can be fixed, or else it
should be guarded by a suitable check that means we don't
try to build it on hosts that don't have the host-specific
functions/whatever that it needs.
thanks
-- PMM