Re: [PATCH 3/4] Allow tests to be disabled

[Alex Bennée]

Manolo de Medici <manolodemedici@gmail.com> writes:

> I agree with you, I mentioned that this was the "minimal effort"
> patchset to get qemu compilable.
>
> On Wed, Jan 17, 2024 at 6:35 PM Peter Maydell <peter.maydell@linaro.org> 
> wrote:
> [...]
>> should be guarded by a suitable check that means we don't
>> try to build it on hosts that don't have the host-specific
>> functions/whatever that it needs.
>
> This is the best solution for this problem, any pointers on how to
> best do this?

Look in tests/qtest/meson.build for lines like:

  config_all_devices.has_key('CONFIG_TPM_TIS_ISA') ? ['tpm-tis-test'] : [])

It seems we have a bunch of logic for qtests_i386 and qtests_aarch64
which isn't applied to the qtests list. Commenting those out I still get
the full list:

 meson test --list | grep tpm
 qemu:qtest+qtest-aarch64 / qtest-aarch64/tpm-tis-device-test
 qemu:qtest+qtest-aarch64 / qtest-aarch64/tpm-tis-device-swtpm-test
 qemu:qtest+qtest-aarch64 / qtest-aarch64/tpm-tis-i2c-test
 qemu:qtest+qtest-arm / qtest-arm/tpm-tis-i2c-test
 qemu:qtest+qtest-i386 / qtest-i386/tpm-crb-test
 qemu:qtest+qtest-i386 / qtest-i386/tpm-crb-swtpm-test
 qemu:qtest+qtest-i386 / qtest-i386/tpm-tis-test
 qemu:qtest+qtest-i386 / qtest-i386/tpm-tis-swtpm-test
 qemu:qtest+qtest-x86_64 / qtest-x86_64/tpm-crb-test
 qemu:qtest+qtest-x86_64 / qtest-x86_64/tpm-crb-swtpm-test
 qemu:qtest+qtest-x86_64 / qtest-x86_64/tpm-tis-test
 qemu:qtest+qtest-x86_64 / qtest-x86_64/tpm-tis-swtpm-test

But I guess there are there to ensure the dependencies are correct so
I'm sure that's not the right fix.

Paolo,

Where is that meant to be done?

>
> Thanks
>
> On Wed, Jan 17, 2024 at 6:35 PM Peter Maydell <peter.maydell@linaro.org> 
> wrote:
>>
>> On Wed, 17 Jan 2024 at 12:59, Manolo de Medici <manolodemedici@gmail.com> 
>> wrote:
>> >
>> > tests/qtest/tpm-* compilation is not disabled by disable-tpm,
>> > for this reason compilation fails on systems that doesn't
>> > support the linux/bsd TPM api. Fix this by allowing tests
>> > to be disabled.
>>
>> This isn't the right way to fix this. Either the tpm test
>> code has portability issues that can be fixed, or else it
>> should be guarded by a suitable check that means we don't
>> try to build it on hosts that don't have the host-specific
>> functions/whatever that it needs.
>>
>> thanks
>> -- PMM

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro