libzstd :: non-regular file test failure

[Diego Nieto Cid]

Hello,

I was looking at the buildd failures of libzstd to try to fix it. It
compiles fine but one of the tests (so far...) fails to run
properly[1]:

    test : should quietly not remove non-regular file
    make[2]: *** [Makefile:352: test-zstd] Error 1
    make[2]: Leaving directory '/<<PKGBUILDDIR>>/tests'
    make[1]: *** [Makefile:85: test] Error 2
    make[1]: Leaving directory '/<<PKGBUILDDIR>>'
    rm -fr -- /tmp/dh-xdg-rundir-VQdgEzxS
    dh_auto_test: error: make -j1 test returned exit code 2
    make: *** [debian/rules:36: binary-arch] Error 255
    dpkg-buildpackage: error: debian/rules binary-arch subprocess
returned exit status 2

The particular command-line that fails is

    + zstd tmp -f -o /dev/random

which produce the following piece of logs:

    $ cat tests/tmplog
    + '[' -z '' ']'
    + ../programs/zstd tmp -f -o /dev/random
    zstd: /dev/random: Permission denied

On GNU Hurd /dev/random is read-only and root owned:

   $ ls -l /dev/random
    crw-r--r-- 1 root root 0, 0 Nov 15 13:54 /dev/random

On the other hand, on GNU/Linux this device is world writable:

    $ ls -l /dev/random
    crw-rw-rw- 1 root root 1, 8 dic  3 10:25 /dev/random

Once I change the permissions:

    $ sudo chmod og+w /dev/random
    $ ls -l /dev/random
    crw-rw-rw- 1 root root 0, 0 Nov 15 13:54 /dev/random

the test no longer fails. \o/

Unfortunately, I couldn't check the other tests yet. dh_auto_test
hangs at one of the bigger files because I need to assign more memory
to the VM. The last thing it prints is:

    fileRoundTripTest: datagen -g4193M -P99 > tmp && zstd -v1 -c tmp | zstd -d1

What would  be the proper fix? Is changing the default permissions ok?

Regards

---
[1] 
https://buildd.debian.org/status/fetch.php?pkg=libzstd&arch=hurd-amd64&ver=1.5.6%2Bdfsg-1%2Bb1&stamp=1731888721&raw=0