Re: libzstd :: non-regular file test failure

[Diego Nieto Cid]

El mar, 3 dic 2024 a las 11:26, Samuel Thibault
(<samuel.thibault@gnu.org>) escribió:
>
> Diego Nieto Cid, le mar. 03 déc. 2024 11:10:57 -0300, a ecrit:
> > which produce the following piece of logs:
> >
> >     $ cat tests/tmplog
> >     + '[' -z '' ']'
> >     + ../programs/zstd tmp -f -o /dev/random
> >     zstd: /dev/random: Permission denied
>
> Eh? Why writing to random? What sense is this supposed to have for
> non-root?

It's testing that a non regular file doesn't fail and rather continues
silently. Not sure why the wouldn't want to error out in such cases
:shrug:

The device node is picked earlier in the test script [1]:

    INTOVOID="/dev/null"
    case "$UNAME" in
      GNU) DEVDEVICE="/dev/random" ;;
      *) DEVDEVICE="/dev/zero" ;;
    esac

>
> And what is surprising is: does it actually work on hurd-i386?
>

Yes, there's a patch to skip de failing tests on hurd-i386 [2]


---
[1] https://github.com/facebook/zstd/blob/dev/tests/playTests.sh#L112
[2] 
https://sources.debian.org/patches/libzstd/1.5.6%2Bdfsg-1/0015-Skip-dev-random-tests-on-hurd.patch/