[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] config patch

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] config patch
Date: Fri, 06 Aug 2010 13:24:54 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

vivi <address@hidden> writes:

> === modified file 'src/ChangeLog'
> --- src/ChangeLog     2010-08-01 20:55:53 +0000
> +++ src/ChangeLog     2010-08-05 17:55:28 +0000
> @@ -1,3 +1,18 @@
> +2010-08-04  Reza Snowdon <address@hidden>
> +
> +       * main.c (main): inserted 'defaults'
> +       * init.c: Include stdbool.h.
> +          (commands):Added config detailsi.

Typo here.

The patch seems fine, except I have noticed some trailing whitespaces
and no space between the function name and '('.  Can you please check

The new option should be documented, can you do it in the doc/wget.texi

Also, it is desiderable to test this new feature, if you like you can
add a new test under the tests/ directory.  I think it will be enough to
feed wget with an incorrect configuration file and check that wget exits
with an error.

Can you please do a "bzr rebase" on your patch before re-send it?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]