Re: [Bug-wget] [PATCH] Using parallel test harness

[Tim Ruehsen]

On Thursday 25 September 2014 15:38:49 Darshit Shah wrote:
> On Thu, Sep 25, 2014 at 11:40:57AM +0200, Tim Ruehsen wrote:
> > Hi,
> >
> > here is patch version #2.
> >
> > - fixed some little scratches
> > - got rid of WgetTest.pm.in (WgetTest.pm now reads $top_srcdir from ENV).
> > - got rid of run-px
> >
> > With these changes you can make use of TESTS_ENVIRONMENT variable, e.g.
> >
> >     TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8" make check -j4
> >
> > To run the tests with a turkish locale.
> > ;-) Some tests break, but I am up to fix a few (e.g. the perl FTP server
> > has a locale issue which I already fixed - patch comes today).
>
> Hi Tim,
>
> A couple of points about this patch. The patch now puts the WgetTest.pm file
> under version control. Everyone who already has a development environment
> for Wget already setup will not be able to apply this patch without manual
> intervention.
>
> Instead, I suggest that we rename WgetTest.pm to something else so that the
> conflict does not arise. It could be called WgetTests.pm for example.

I wasn't aware of that. I'll rename WgetTest.pm to WgetTests.pm as you
suggest.

> The WgetTest.pm file included in this patch contains the old Warning for an
> autogenerated file. Maybe we should remove that one since the file is no
> longer being autogenerated.

I agree.

> Do you think having the tests being run in a different locale is necessary?

Yes - definitely. There are Wget bugs that come out only when running the
tests with a different locale than C. The test suite should be fixed so that
it works for any non-developer who downloads the source, compiles and tests it
(make check). These people want to know that Wget correctly works on their
system which also includes their current locale. But this at a later time.

Right now, by default the tests run with LC_ALL=C. This can only be changed by
setting TESTS_ENVIRONMENT. So for the moment, nothing changes for anybody by
default. Though developers now have the possibility to use TESTS_ENVIRONMENT
which doesn't work for the old serial test suite.

At least here, I still get english messages from the test suite, even with
        TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8" make check -j4
(is it LC_MESSAGES still being en_US.UTF-8 ? have to make some tests...)

Of course, should the test suite messages be english - that is what people
send to the developers.

patch version #3 is attached

Tim

0001-Switched-to-parallel-test-harness.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part.